jorisschellekens / borb

borb is a library for reading, creating and manipulating PDF files in python.
https://borbpdf.com/
Other
3.4k stars 147 forks source link

Large bundled resources should be moved into separate packages. #116

Closed KOLANICH closed 2 years ago

KOLANICH commented 2 years ago

Is your feature request related to a problem? Please describe. I don't need them.

Describe the solution you'd like Their installation made optional.

jorisschellekens commented 2 years ago

Do you have a suggested solution? I'm not an expert on Python packaging. And I've been trying a few things with both MANIFEST.in and setup.py but nothing seems to work properly.

KOLANICH commented 2 years ago

I suggest to create separate packages for them and add them into optional dependencies. Also make them universal enough to encourage their reuse by other packages. I have seen quite some packages that bundle resources too, causing absolutely unnecessary bloat.

jorisschellekens commented 2 years ago

Fixed

KOLANICH commented 2 years ago

Thanks.