search

jorisvddonk / node-red-contrib-discord

Node-red nodes that allow you to interact with Discord.
15 stars 19 forks source link

Update to Discord.js 12, add delete node, add edit feature #29

Closed Markoudstaal closed 3 years ago

Markoudstaal commented 3 years ago

No breaking changes.

jorisvddonk commented 3 years ago

Hi! Thanks so much for the PR! 👍 A quick readthrough doesn't reveal anything particularly worrisome, but I'll have to give it a try myself and I'd like to give it a closer look as well. Hopefully I'll be able to get that done sometime in the next week.

Markoudstaal commented 3 years ago

Hi! Thanks so much for the PR! 👍

A quick readthrough doesn't reveal anything particularly worrisome, but I'll have to give it a try myself and I'd like to give it a closer look as well. Hopefully I'll be able to get that done sometime in the next week.

Hey Joris! Any chance you've been able to take a look yet?

ozdeadmeat commented 3 years ago

Has this been integrated yet? This has a bunch of new features that I need.

jorisvddonk commented 3 years ago

Hi! Sorry for the delay; I haven't been able to look at it before my vacation, and now I'm no longer at home with limited connectivity and power and without my usual workstation, so taking a look is going to be be difficult until I get some good connectivity and a chance to figure out how to make things work on my Chromebook.

In the meantime I recommend using a git:// URL in your package JSON, or uploading your own module to NPM.

jorisvddonk commented 3 years ago

(maintainer notice: this fixes #28 for users that have Discord.js 12 installed)

jorisvddonk commented 3 years ago

(maintainer notice: this implements #16 )

jorisvddonk commented 3 years ago

(maintainer notice: this fixes #8 for Discord.js 12 users)

Markoudstaal commented 3 years ago

Hey Joris, since we needed to have the new functionality up on npm I created a new repository. You can find it here: https://github.com/Markoudstaal/node-red-contrib-discord-advanced Ofcourse I do mention your work in there but we are quite a few features, nodes and pushes ahead now and there's already some people using it in node-red. Therefor I don't think merging would be the way to go anymore.

jorisvddonk commented 3 years ago

Hey Joris, since we needed to have the new functionality up on npm I created a new repository. You can find it here: https://github.com/Markoudstaal/node-red-contrib-discord-advanced Ofcourse I do mention your work in there but we are quite a few features, nodes and pushes ahead now and there's already some people using it in node-red. Therefor I don't think merging would be the way to go anymore.

Great! That's probably the best way to go forward. I've applied the requested changes and merged with master, and will probably cut a release later, as the update to Discord.js 12 is pretty sweet and it resolves some issues people have been having. Thanks again for the PR, and good luck with your fork!