jorisvddonk / system-reset

System Reset - Re-implementation of Noctis IV, in Godot

10 stars 1 forks source link

Fix day/night terminator of planets in space #2

Closed jorisvddonk closed 8 months ago

jorisvddonk commented 1 year ago

At the moment, the day/night terminator of planets in space is completely misaligned, and the 'dark side' of planets is often pointed the wrong way.

The above example screenshot demonstrates the issue nicely; the star is to the right here, but somehow the texture of the planet is rotated such that the day/night side is not aligned with the positioning in 3d of all of the objects in the space_local_system scene.

jorisvddonk commented 1 year ago

This is a particularly notorious bug that I thought I fixed many times, but it keeps coming back in certain cases. Make sure that it's tested for various different star systems and different planets orbiting them; Ylastravenya and Balastrackonastreya in particular.

3 probably impacts this bug as well; it may be useful to fix that one first.

jorisvddonk commented 8 months ago

NOPE, this one is back, sigh. Reopening.

jorisvddonk commented 8 months ago

It seems that in certain cases, loading a game can fix it? There must be some variable not getting set correctly if you just move around the universe normally or via the st command. That also explains why I keep thinking this bug is fixed: whenever I try tackling it, I'm actively loading the game to make development quicker...