josa42 / atom-blame

Show git blame as a gutter in Atom editor
https://atom.io/packages/blame
MIT License
22 stars 18 forks source link

Add possibility to copy the commit hash to clipboard #3

Closed hasrthur closed 9 years ago

hasrthur commented 9 years ago

Sometimes it is useful to not only see who commited the line, but also to copy the hash of commit to examine the whole commit in somewhere else (e.g. in SourceTree)

josa42 commented 9 years ago

Nice! Thanks for the PR.

Just a small thing, could you move the icon to the end of the line?

josa42 commented 9 years ago

Also, the icon seems to mess with the line-height. This can be resolved, by change the position of .icon-copyto absolute:

Add to .icon-copy

position: absolute;
right: 0;

And change .blame-gutter-inner to:

padding: 0 25px 0 5px;

screen shot 2015-08-04 at 11 45 22

I am just not sure how to deal with different text sizes.

Small: screen shot 2015-08-04 at 11 46 37

Big: screen shot 2015-08-04 at 11 46 54

hasrthur commented 9 years ago

hm... I will think about the text sizes