Open gilbertohasnofb opened 4 years ago
With some help I got today from JerrySv upgrading my code I should be able to compile a version for v1.x now.
Would you like me to do additional migration cleanup so your plugin compiles without warnings?
Hi,
well, so much help in one day! Who would have thought this would happen?
And yes, any help is appreciated.
Best regards,
Jos
On 18 Oct 2019, at 23:48, Netboy3 notifications@github.com wrote:
Would you like me to do additional migration cleanup so your plugin compiles without warnings?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/josbouten/Sculpt-O-Sound/issues/3?email_source=notifications&email_token=ACE2N5LOU4XMYEEWVUW7DQTQPIVKVA5CNFSM4IVY6NZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBWEKLY#issuecomment-543966511, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE2N5NYDJFEJYEDOPVK4TLQPIVKVANCNFSM4IVY6NZA.
Hi Jos,
Just dropped a Pull-Request for you. I believe this PR will bring your plugin to be ready for production. It builds nicely and is much faster than before. Please let me know if you have any questions. I would love to finally see it available in the plugin manager.
Hi Jos,
Is everything working OK after the init issue fixup? Are we ready for another plugin in the manager? :smile:
Hi Netboy3,
Good of you to ask!
I was planning on putting it up for release this weekend. Before I do so I want to go through the code once more and clean it up a bit where necessary and maybe add some more comments. I’ve been reading up on the request to change the licensing and need to decide about that as well. It’s just that last weekend and this week I’ve been really busy otherwise you would have seen the module in the library already. So it takes a bit more patience and then I hope people will use it and I get some feedback.
Best regards,
Jos
On 1 Nov 2019, at 16:45, Netboy3 notifications@github.com wrote:
Hi Jos,
Is everything working OK after the init issue fixup? Are we ready for another plugin in the manager? 😄
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/josbouten/Sculpt-O-Sound/issues/3?email_source=notifications&email_token=ACE2N5NK5RKFN37JSEO2AXTQRRFKTA5CNFSM4IVY6NZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3JV6Q#issuecomment-548838138, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE2N5KZWFYCW4Z2HSPRBVLQRRFKTANCNFSM4IVY6NZA.
Your plugin is not compatible any longer with the current version of VCV Rack. Are you planning on updating it and releasing a new version?