joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)
http://joscha.github.com/play-authenticate/
Other
807 stars 366 forks source link

EventBrite Auth Provider Pull request #191

Closed thandaanda closed 10 years ago

thandaanda commented 10 years ago

Please check the code and merge.

Cheers.

joscha commented 10 years ago

Thank you! Looks good! Can you remove the unused interfaces from the EventbriteAuthUser instead of returning null and bump the play-authenticate version in all the projects and make sure the build runs through?

joscha commented 10 years ago

And if you can, a test would be amazing. There is one for the Google OAuth provider on which you can base it on. I can then get the credentials and add them to this PR.

thandaanda commented 10 years ago

Will do that. On 5 Jul 2014 17:00, "Joscha Feth" notifications@github.com wrote:

And if you can, a test would be amazing. There is one for the Google OAuth provider on which you can base it on. I can then get the credentials and add them to this PR.

— Reply to this email directly or view it on GitHub https://github.com/joscha/play-authenticate/pull/191#issuecomment-48084202 .

thandaanda commented 10 years ago

I checked the code I was compiling with different version of play.will update

thandaanda commented 10 years ago

I think there is issue with travis build box - getting " There is insufficient memory for the Java Runtime Environment to continue."

joscha commented 10 years ago

@thandaanda I restarted it, could you change

clientId=
...=

into

# clientId=
# ...=

please?

thandaanda commented 10 years ago

Give me a minute On 8 Jul 2014 18:19, "Joscha Feth" notifications@github.com wrote:

@thandaanda https://github.com/thandaanda I restarted it, could you change

clientId= ...=

into

clientId=

...=

please?

— Reply to this email directly or view it on GitHub https://github.com/joscha/play-authenticate/pull/191#issuecomment-48331210 .

thandaanda commented 10 years ago

Sigh!!!

joscha commented 10 years ago

:-) Nice!

joscha commented 10 years ago

I'll have a look at it tonight and try and write a test for it.

thandaanda commented 10 years ago

Okay, thanks!!

joscha commented 10 years ago

Thank you for this!