Closed thandaanda closed 10 years ago
Thank you! Looks good! Can you remove the unused interfaces from the EventbriteAuthUser instead of returning null and bump the play-authenticate version in all the projects and make sure the build runs through?
And if you can, a test would be amazing. There is one for the Google OAuth provider on which you can base it on. I can then get the credentials and add them to this PR.
Will do that. On 5 Jul 2014 17:00, "Joscha Feth" notifications@github.com wrote:
And if you can, a test would be amazing. There is one for the Google OAuth provider on which you can base it on. I can then get the credentials and add them to this PR.
— Reply to this email directly or view it on GitHub https://github.com/joscha/play-authenticate/pull/191#issuecomment-48084202 .
I checked the code I was compiling with different version of play.will update
I think there is issue with travis build box - getting " There is insufficient memory for the Java Runtime Environment to continue."
@thandaanda I restarted it, could you change
clientId=
...=
into
# clientId=
# ...=
please?
Give me a minute On 8 Jul 2014 18:19, "Joscha Feth" notifications@github.com wrote:
@thandaanda https://github.com/thandaanda I restarted it, could you change
clientId= ...=
into
clientId=
...=
please?
— Reply to this email directly or view it on GitHub https://github.com/joscha/play-authenticate/pull/191#issuecomment-48331210 .
Sigh!!!
:-) Nice!
I'll have a look at it tonight and try and write a test for it.
Okay, thanks!!
Thank you for this!
Please check the code and merge.
Cheers.