search

joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)
http://joscha.github.com/play-authenticate/
Other
807 stars 367 forks source link

- support for play 2.4 #249

Closed vmouta closed 9 years ago

vmouta commented 9 years ago
mkurz commented 9 years ago

@joscha Play 2.4.0 RC1 is out now. Are there plans to upgrade play-authenticate and play-easymail to Play 2.4 soon?

joscha commented 9 years ago

@mkurz I haven't looked into it, yet - have you checked the deps @vmouta is talking about?

mkurz commented 9 years ago

@joscha Sorry, I haven't had time this week - hopefully next week I can have a look.

mkurz commented 9 years ago

@joscha he is talking about https://github.com/schaloner/deadbolt-2-java/pull/6 and https://github.com/webjars/webjars-play/pull/50. However the second dependency webjars-play is not necessary anymore. See my next comment why.

mkurz commented 9 years ago

@vmouta Could you please update this PR?

Following things need to be done:

The dependency to webjars-play ("org.webjars" %% "webjars-play" % "2.4.0-SNAPSHOT") (see here) can be completely removed, Play handles this already. After removing this dependency you now have to remove these two lines as well and instead use only this one now:

GET     /assets/*file               controllers.Assets.versioned(path="/public", file: Asset)

This change then requires to change these two lines to these ones:

<script type="text/javascript" src="@routes.Assets.versioned("lib/jquery/jquery.js")"></script>
<script type="text/javascript" src="@routes.Assets.versioned("lib/bootstrap/bootstrap.js")"></script>

That's how it should be done in Play now.

Please also see my comments in the diffs.

mkurz commented 9 years ago

@vmouta Oh and thanks for the work!

mkurz commented 9 years ago

Ping @vmouta - are you keen to update this PR? Play 2.4.0-RC5 was released today and it will probably be the last RC, so it would be nice if we could get this library here working.

mkurz commented 9 years ago

@joscha @vmouta isn't responding, I even wrote him an email a couple of days ago. I will not have time at least until tuesday to work on this, maybe you have some free hours over the weekend to have a look? (RC5 will most likely be the last RC as far as I know)

joscha commented 9 years ago

@mkurz I'll see if I can look at it on Monday. Won't have time over the weekend either, unfortunately.

vmouta commented 9 years ago

Sorry was away for a while will have a look again starting from tomorrow...

On 22 May 2015, at 12:49, Joscha Feth notifications@github.com wrote:

@mkurz https://github.com/mkurz I'll see if I can look at it on Monday. Won't have time over the weekend either, unfortunately.

— Reply to this email directly or view it on GitHub https://github.com/joscha/play-authenticate/pull/249#issuecomment-104616748.

mkurz commented 9 years ago

@vmouta Very cool! Thanks a lot! :smile:

mkurz commented 9 years ago

@vmouta FYI: Play 2.4 has been released a few hours ago! (https://groups.google.com/forum/?fromgroups#!topic/play-framework/gXYhA-BiSqk) Hopefully we can get play-authenticate up and running soon :smile:

keepscoding commented 9 years ago

+1. keep it up..

mkurz commented 9 years ago

As it looks like @vmouta does not have time for any further work on this pull request, I will definitly start working to upgrade this module to Play 2.4 on Monday (I am on holiday til Sunday evening). We want to upgrade our Play projects to Play 2.4 next week and we do not want to postpone it any longer. I will let you know when I am finished.

esolomka commented 9 years ago

@mkurz how is it going? looking forward to test...

dan-lind commented 9 years ago

Looks like the build is failing because Play 2.4 requires Java 8?

keepscoding commented 9 years ago

Yes. You have to use Jave 8 and later. https://www.playframework.com/documentation/2.4.x/Migration24#Java-8-support If not, you will get 

java.lang.UnsupportedClassVersionError

That'y all the Java 6 & 7 build fail.

mkurz commented 9 years ago

I am working on this, I will provide a PR today.

mkurz commented 9 years ago

Closing in favor of #258

mkurz commented 9 years ago

@vmouta @esolomka @dan-lind @keepscoding 0.7.0-SNAPSHOT with Play 2.4 support is available on sonatype now! Please test and let us know how it goes, thanks!