joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)
http://joscha.github.com/play-authenticate/
Other
807 stars 367 forks source link

Make identity interface inner classes serializable to fix caching exception #292

Closed EvanDooner closed 8 years ago

EvanDooner commented 8 years ago

This fixes #291. In addition to making the EmploymentsIdentity.EmploymentInfo class implement the Serializable interface, the same change has been made to EducationsIdentity.EducationInfo, as it is vulnerable to the same problem.

Local testing shows that linking a LinkedIn account to an existing user account now completes normally.

joscha commented 8 years ago

Thanks for this!

joscha commented 8 years ago

This should probably be pulled upstream as well...