search

joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)
http://joscha.github.com/play-authenticate/
Other
807 stars 367 forks source link

Fixing sample usage tests #299

Closed pdolega closed 8 years ago

pdolega commented 8 years ago

Fix for the issue described here: https://github.com/joscha/play-authenticate/pull/298#issuecomment-205277565

pdolega commented 8 years ago

@joscha ^^ I think this might just fix test failures that prevent 0.8 from being published.

joscha commented 8 years ago

Thanks @pdolega - there are still some selenium problems, however probably not related to the upgrade - the weird thing is, however that I am not able to run the tests locally any more - have you tried running them with the command provided in #298?

joscha commented 8 years ago

got the tests working. fixed one of them, one is still broken and needs a bit of selenium-massaging.

joscha commented 8 years ago

all green - 0.8.0-SNAPSHOT has been released.

pdolega commented 8 years ago

Sorry for late answer @joscha

Thanks @pdolega - there are still some selenium problems, however probably not related to the upgrade - the weird thing is, however that I am not able to run the tests locally any more - have you tried running them with the command provided in #298?

I did manage to run them (saw browser being fired), saw Google authentication being performed successfully (only one I tried end 2 end - with my actual credentials). As for the rest I only verified that browser appeared, incorrect credentials have been specified (basically XXX everywhere) and at that point it obviously failed.

My mistake - thought it would be sufficient.

joscha commented 8 years ago

All good no worries, thank you very much for your contrib. Let me know if 0.8.1-SNAPSHOT works for you!