search

joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)
http://joscha.github.com/play-authenticate/
Other
807 stars 367 forks source link

Fix for easy-mail 0.8.0-SNAPSHOT compatibility #301

Closed oexza closed 8 years ago

joscha commented 8 years ago

Thanks for this. I think before merging this I want to revisit moving the constants from the interface into the implementation - it seems as if the abstraction we had in play-easymail is not really given any more. It seems as if using it became more complex with the last snapshot unfortunately.

oexza commented 8 years ago

@joscha you do have a point. i should have made the implementation as lean as possible. i'll see to it in a bit

On 4/6/16, Joscha Feth notifications@github.com wrote:

Thanks for this. I think before merging this I want to revisit moving the constants from the interface into the implementation - it seems as if the abstraction we had in play-easymail is not really given any more. It seems as if using it became more complex with the last snapshot unfortunately.

You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/joscha/play-authenticate/pull/301#issuecomment-206038385

oexza commented 8 years ago

ok i've submitted a pr on the easymail project

joscha commented 8 years ago

I think that overlapped with my changes...

joscha commented 8 years ago

closed via db2bdb9