search

joschi70 / AndroidPirateBox

Android version of PirateBox
MIT License
73 stars 16 forks source link

Crash when max upload size > max int #2

Closed benwaffle closed 10 years ago

benwaffle commented 10 years ago

If you set the maximum upload size to greater than 231-1, the app crashes. I think its just best to make it a long (~9 million TB) rather than limit it to 2 GB.

joschi70 commented 10 years ago

The underlying Brazil framework limits the upload size to 2 GB. The framework would have to be re-written to change this. What can be done is to limit the upload size to 2 GB inside the preferences, so that the app will no longer crash.

joschi70 commented 10 years ago

Just tried to change the framework. This has too many side effects, so it's currently not possible to increase the upload size. The next PirateBox version (0.4.9 beta) will check for a valid size so that the server does not crash.

joschi70 commented 10 years ago

Closing the issue for now...