search

josdejong / jsoneditor

A web-based tool to view, edit, format, and validate JSON
http://jsoneditoronline.org
Apache License 2.0
11.62k stars 2.04k forks source link

isValidationErrorChanged does not compare the error messsage #1627

Open Tethys0 opened 6 days ago

Tethys0 commented 6 days ago

isValidationErrorChanged does not compare the messsage , if we have the same count of error message in the error array, though message is different , it won't trigger "onValidationError"

https://github.com/josdejong/jsoneditor/blob/develop/src/js/util.js#L1233https://github.com/josdejong/jsoneditor/blob/develop/src/js/util.js#L1233

We use custom validation and rely on onValidationError hook to reset the form control error.

josdejong commented 5 days ago

Thanks for reporting! We should improve this isValidationErrorChanged function.

Anyone able to help fix this? Help would be welcome.