josdejong / svelte-jsoneditor

A web-based tool to view, edit, format, repair, query, transform, and validate JSON
https://jsoneditoronline.org
Other
814 stars 108 forks source link

Open a link via Ctrl + Click doesnt work #436

Closed derldalfor100 closed 3 weeks ago

derldalfor100 commented 1 month ago

Please fix it or provide a better way other than Ctrl + Enter to open a link

josdejong commented 1 month ago

Thanks for your input. I just tested and Ctrl+Enter works fine to open urls. How can I reproduce your issue exactly?

derldalfor100 commented 1 month ago

Hi @josdejong, Ctrl+Enter works for me too however Ctrl + Click doesnt work. You can reproduce that in the playground. The title attribute guides us both ways should work.

josdejong commented 1 month ago

I've opened the playground example in Firefox and Chrome, there Ctrl+Enter and Ctrl+Click on a url does work as expected (opening the url in a new tab).

What browser/OS are you using?

derldalfor100 commented 1 month ago

@josdejong Sorry for the misunderstanding. I'm using version 0.23.2 of vanilla-jsoneditor. And as you can see here https://jsoneditoronline.org/#left=local.bajowo&right=local.ramawi it doesnt work with Ctrl + Click. I'm using Brave and Chrome.

derldalfor100 commented 1 month ago

@josdejong One more note. The bug doesn't happen in Windows. Im mainly using Mac and it appears also in the Svelte playground.

josdejong commented 1 month ago

The bug doesn't happen in Windows.

Ah, now that is a clear clue. I'm indeed running Windows. So, probably the mapping for the Command key doesn't work as it should.

Help debugging this issue would be welcome, it's not easy for me to test in a reliable way.

josdejong commented 3 weeks ago

This issue has been fixed now in v0.23.6.