Closed josdejong closed 2 years ago
Looks reasonable to me. I just added the typed-function creation count stuff as that will be necessary for interpreting future mathjs benchmarks, so it seemed appropriate here. Will merge and then further validate these benchmarks by trying them on the version of "prefer conversion to any" that showed a slowdown in mathjs "load all".
👍
I extended the benchmark section to compare creating/executing of typed functions with varying number of signatures, conversions, params. This can be used compare for regressions/improvements when implementing new features or refactoring stuff.
Example output:
@gwhitney can you have a look at this PR? Feel free to merge it right away in
develop
. And feel free to make further improvements if needed.