search

josdejong / workerpool

Offload tasks to a pool of workers on node.js and in the browser
Apache License 2.0
2.06k stars 147 forks source link

fix: missing workerThreadOpts on terminate worker #376

Closed Michsior14 closed 1 year ago

Michsior14 commented 1 year ago

Adds missing workerThreadOpts on terminate hooks.

Michsior14 commented 1 year ago

@josdejong Any review ETA?

josdejong commented 1 year ago

@Michsior14 I plan to review your 3 PR's tomorrow.

josdejong commented 1 year ago

Looks good, thanks for this improvement Michał!

josdejong commented 1 year ago

@Michsior14 when do you expect to be able to finish #377 and #374? If that is soon I'll wait publishing to npm until those two PR's are merged too.

Michsior14 commented 1 year ago

@Michsior14 when do you expect to be able to finish #377 and #374? If that is soon I'll wait publishing to npm until those two PR's are merged too.

Today or during the weekend ;)

josdejong commented 1 year ago

💪

josdejong commented 1 year ago

Published now in v6.4.0, thanks again, this is quite a major release :)