josdem / vetlog-spring-boot

Maintain your pet history organized
https://vetlog.org
Apache License 2.0
21 stars 19 forks source link

Create vaccination model #304

Closed josdem closed 2 months ago

josdem commented 2 months ago

As a user, I want to create a vaccination model so that I can register next vaccination for my pet.

Acceptance Criteria

References

kaminuma commented 2 months ago

Hi Wanting to contribute for the first time, I set up a local environment. For this issue, should I create a model file with the above items in the model directory in MVC? If the recognition is correct, please assign it.

josdem commented 2 months ago

Hi Wanting to contribute for the first time, I set up a local environment. For this issue, should I create a model file with the above items in the model directory in MVC? If the recognition is correct, please assign it.

Hi @kaminuma your understanding regarding this issue/task is correct; I assigned this issue/task to you. Please notice you can get vaccine names from the vaccionation program link. Your colaboration is appreciated!.

kaminuma commented 2 months ago

thanks I got it First, let's go as far as cutting a branch feature/304 and issuing a PR.

kaminuma commented 2 months ago

@josdem

fatal: unable to access 'https://github.com/josdem/vetlog-spring-boot.git/': The requested URL returned error: 403
Pushing to https://github.com/josdem/vetlog-spring-boot.git

I created a model file, so I tried to push it, but it seems like I don't have permissions. Please give me push permission. Also, is it okay to create only the model file this issue?

josdem commented 2 months ago

@josdem

fatal: unable to access 'https://github.com/josdem/vetlog-spring-boot.git/': The requested URL returned error: 403
Pushing to https://github.com/josdem/vetlog-spring-boot.git

I created a model file, so I tried to push it, but it seems like I don't have permissions. Please give me push permission. Also, is it okay to create only the model file this issue?

Hi @kaminuma I sent you a collaboration invite, once you accept you should be able to push your branch, also yes for this issue is only required the file with the model class defined. Thank you!

kaminuma commented 2 months ago

@josdem I checked the collaborators and pushed. Please check PR

josdem commented 2 months ago

PR merged: https://github.com/josdem/vetlog-spring-boot/pull/310