josdem / vetlog-spring-boot

Maintain your pet history organized
https://vetlog.org
Apache License 2.0
21 stars 21 forks source link

Create next vaccines for a Cat pet based on its birthdate #342

Closed josdem closed 1 month ago

josdem commented 1 month ago

As a user, I want to create next vaccination records for my Cat pet based on its birthdate so that I can schedule next vaccination days.

Acceptance Critera

Notes

ghadyg commented 1 month ago

Hello, I can work on this, but I have a question, there is already one for the dog when you register a new pet. Do you want a similar implementation?

josdem commented 1 month ago

Hello, I can work on this, but I have a question, there is already one for the dog when you register a new pet. Do you want a similar implementation?

Hi @ghadyg; thanks for offering to solve this issue, please go ahead and implement a similar implementation for cat pets, basically you need to add an if conditional statement and a switch with cat's vaccines based on its birthday. However, I am planing to implement a design pattern here, which I can do after you send a PR.

This one: https://refactoring.guru/design-patterns/strategy

ghadyg commented 1 month ago

If you want I can do this one using the design pattern strategy and once I send a PR you can check it and modify It as you see fit

josdem commented 1 month ago

If you want I can do this one using the design pattern strategy and once I send a PR you can check it and modify It as you see fit

Sounds good to me, thank you!

josdem commented 1 month ago

Hi @ghadyg , I sent you a collaboration request, so that you can create a branch directly from this main repository, you will help me to validate your changes easily. Thank you!

Aditionally, your tests will pass since it will be set MySQL database credentials.

josdem commented 1 month ago

PR merged: https://github.com/josdem/vetlog-spring-boot/pull/358