josdemmers / Diablo4Companion

A companion app for Diablo IV to help you find your perfect gear affixes.
MIT License
229 stars 37 forks source link

Blood mist affix imported as Stunt duration D4Build #108

Closed Saharash closed 4 months ago

Saharash commented 4 months ago

image image build: https://d4builds.gg/builds/ef414fbd-81cd-49d1-9c8d-4938b278e2ee/?var=0

Saharash commented 4 months ago

image And inherent affix still didn't import from d4build, last update 3.4.6.0

josdemmers commented 4 months ago

The Resistance to all elements only works when it's included: d4builds (missing) image

Maxroll (included) image

josdemmers commented 4 months ago

Will have to check what is happening with the Blood mist affix. Probably because the extra text d4builds uses to describe the tempered affixes.

josdemmers commented 4 months ago

Did some tests. Both inherent and tempered will not always work for d4builds because of the different affix descriptions they use. That will cost some more time to get that working again.

Saharash commented 4 months ago

Owner

Alright thanks !

josdemmers commented 4 months ago

I think I found most of the issues, got a few questions thought.

Do you know how this one looks ingame?

Diablo 4 Companion: Golem Cooldown Reduction (Necromancer Only)

d4builds: [16 - 25%] Golem Active Cooldown Reduction (Necromancer Efficiency - Resource)

With or without the active part?

And the second one, in the build you linked there is a strange tempered affix on the pants. Screenshot 2024-05-29 145052

Looks like two different affixes merged together? However the Blight Slow Potency does not exist in my data.

Saharash commented 4 months ago

The first answer looks like that: image

And for the second, there is this: image

josdemmers commented 4 months ago

I think it will work good enough to find Golem Active Cooldown Reduction instead of Golem Cooldown Reduction. But I'll will need to look into that later why my text is different.

And for the second, there is this:

So a bug on d4builds then? Looks like the added the whole temper manual instead of a single affix.

// edit

But then I'll still need to find that Blight Slow Potency affix. Although I'm sure I have added all tempered affixes I could find in the data.

josdemmers commented 4 months ago

But then I'll still need to find that Blight Slow Potency affix. Although I'm sure I have added all tempered affixes I could find in the data.

Found it, it's one of those affixes that is saved differently in the data. There are about 30+ more affixes like that. Still need to figure out how to get those. So the next update will fix most of your issues but the Blight Slow Potency will have to wait.

josdemmers commented 4 months ago

With v3.4.7.0 you will be able to import the tempered affixes. Blight Slow Potency will follow later.

Saharash commented 4 months ago

With v3.4.7.0 you will be able to import the tempered affixes. Blight Slow Potency will follow later.

Thanks sir, i have see also like 3 different affix that was bad imported, i don't remember them all but i know one is on this build: https://d4builds.gg/builds/ef414fbd-81cd-49d1-9c8d-4938b278e2ee/?var=0

Weapons is importing Attack speed at tempered affix, but it's MINION attack speed.

And for the others i have to check if i can remember, but yeah there was more bad imported, i let you know

Saharash commented 4 months ago

Edit: Minion attack speed got fixed in the last version, will let you know if i find wrong values, thanks for the update!

Saharash commented 4 months ago

Edit2, sorry for spam, but i guess since last diablo update, they changed icon of greater affix, and all greater affix aren't recognized anymore with diablo companion

josdemmers commented 4 months ago

No problem, let me know when you find any. For the ef414fbd-81cd-49d1-9c8d-4938b278e2ee build the only one left is the Blight Slow Potency. All others worked when I checked them.

they changed icon of greater affix, and all greater affix aren't recognized anymore with diablo companion

Fixed that this morning for all the 1080p and 1440p system presets. Should work again if you update the system preset under settings.

Saharash commented 4 months ago

Alright thanks sir i didn't updated i thought it was automatically done.

I have a pretty nice suggestion, i don't know if it would be possible but:

It would be great if we can set different affix for Ring 1 and Ring 2, same for all different weapons from barbarian, because we need 4 different weapons but affix is show same for all

josdemmers commented 4 months ago

You could try to do that by using different colors for the affixes.

josdemmers commented 4 months ago

Added the missing Blight Slow Potency as well. Will be available in the next release.