search

jose-elias-alvarez / null-ls.nvim

Use Neovim as a language server to inject LSP diagnostics, code actions, and more via Lua.
Other
3.64k stars 791 forks source link

ts-standard support #834

Open Suyashtnt opened 2 years ago

Suyashtnt commented 2 years ago

Issues

Feature description

Add support for the typescript version of standardjs, ts-standard

Help

Yes, but I don't know how to start. I would need guidance

Implementation help

~~Could I just copy paste code from the normal standard one? They both share the same API Also, how can I write tests?~~ done both. PR soon:tm: How can I get the file name when declaring the args? Since the formatted version goes to stdout, how can I put that into the file its formatting?

jose-elias-alvarez commented 2 years ago

I suspect the standardjs formatter can be adapted to work in this case (by default, most of our formatters will read from stdout and apply changes to the buffer, so that shouldn't be an issue).

Suyashtnt commented 2 years ago

I suspect the standardjs formatter can be adapted to work in this case (by default, most of our formatters will read from stdout and apply changes to the buffer, so that shouldn't be an issue).

for me it did not for some reason. How can i tell it to do so? Its the only thing holding me back from PRing

jose-elias-alvarez commented 2 years ago

You can try enabling debug mode and see what the output looks like.

Suyashtnt commented 2 years ago

image what

jose-elias-alvarez commented 2 years ago

No idea. If you open up a draft PR with what you have so far, I can take a closer look and see if anything jumps out at me.

jose-elias-alvarez commented 2 years ago

For reference: #1033 will close this issue and should provide a good base if anybody wants to pick this up.