search

jose-elias-alvarez / nvim-lsp-ts-utils

Utilities to improve the TypeScript development experience for Neovim's built-in LSP client.
The Unlicense
438 stars 18 forks source link

Feature Request: Allow disabling eslint functionality #22

Closed marcelbeumer closed 3 years ago

marcelbeumer commented 3 years ago

Would be great to have a enable_eslint = false or so in the options.

By installing eslint_d you only feel the startup time once, but I usually don't use eslint while editing code and prefer completely disabling it.

jose-elias-alvarez commented 3 years ago

I'm a little confused – are you referring to diagnostics? If so, there is an eslint_enable_diagnostics settings that (I think) does what you want. Or do you mean that you want to start Neovim with diagnostics disabled and potentially toggle them later?

marcelbeumer commented 3 years ago

No I meant to also disable eslint for code actions, for which I can only set a different eslint_bin as far as I can see.

(I noticed as suddenly code actions became very slow, then installed estlint_d but rather not)

jose-elias-alvarez commented 3 years ago

Ah, understood. The lack of a setting to disable code actions is a bit of a relic, but I can see that it's necessary, especially for users who don't want to switch to eslint_d. It should be trivial to implement, so I'll take care of it the next time I work on the plugin (or a PR would be appreciated!).

marcelbeumer commented 3 years ago

Great! I still have to get my hands dirty with Lua dev, this may be a good opportunity, feel free to assign to me, will make some time somewhere this week.

jose-elias-alvarez commented 3 years ago

Awesome, let me know if you need any guidance on this.