search

jose-elias-alvarez / nvim-lsp-ts-utils

Utilities to improve the TypeScript development experience for Neovim's built-in LSP client.
The Unlicense
437 stars 18 forks source link

Update issue templates #53

Closed vuki656 closed 3 years ago

vuki656 commented 3 years ago
jose-elias-alvarez commented 3 years ago

Thank you for this! The only small thing I would change is the description of the debug log, since it's more about reporting on what the plugin is doing internally (unhandled exceptions should show a proper error stack trace regardless of the option). I think we can make the same change to the null-ls debug description too.

vuki656 commented 3 years ago

Sure thing.

What did you have in mind?

jose-elias-alvarez commented 3 years ago

I think something simple and non-specific like "Debug output from :messages" would work.

vuki656 commented 3 years ago

Done, feel free to merge.

Also added it to null-ls

While you're here, do you think adding a pipeline would be useful? I could set that up.

For example to run stylua on pull requests?

jose-elias-alvarez commented 3 years ago

Thank you so much! I was thinking about running stylua automatically too, since not everybody runs it and I don't want to create a lot of useless commits (which is something I've seen in a lot on other plugins recently). That would be a huge help too.

vuki656 commented 3 years ago

Thank you so much! I was thinking about running stylua automatically too, since not everybody runs it and I don't want to create a lot of useless commits (which is something I've seen in a lot on other plugins recently). That would be a huge help too.

Wait, not sure I follow, would you like to have stylua run on PRs or?

True that that would result in extra commits just for code style but those can either be squashed or if you have diagnostics on, handled right in the editor.

jose-elias-alvarez commented 3 years ago

In short: yes, let's set it up, if it's not too much trouble.