Closed nawordar closed 3 years ago
Sure, I think it makes sense to implement this here, and I agree that that's the right approach. Your implementation looks good – let me look into this a bit more and I'll see what makes sense.
Edit: I think it would also be nice if we could make it easier for users to filter diagnostics by level, since I know a common complaint re: typescript-language-server
is the inability to filter out things like the CommonJS module diagnostic.
Issues
Feature description
typescript-language-server in combination with a linter such as ESLint results in duplicated diagnostics, such as the diagnostic about unused variables. Both VSCode and coc offer such an option, but it is not yet built in typescript-language-server (see: https://github.com/neovim/nvim-lspconfig/issues/997).
Help
Yes, but I don't know how to start. I would need guidance
Implementation help
I have made a crude implementation in my config:
I'm not sure where I would need to put it.
client.lua
seems to be the most fitting place. Maybe checking for an appropriate option insiderequire('nvim-lsp-ts-utils.client').setup
and then setting the wrapper would be a good idea?