search

jose-elias-alvarez / nvim-lsp-ts-utils

Utilities to improve the TypeScript development experience for Neovim's built-in LSP client.
The Unlicense
438 stars 18 forks source link

Support 'typescript' as LSP client name #67

Closed jason0x43 closed 2 years ago

jason0x43 commented 3 years ago

nvim-lspinstall uses a different naming scheme than lspconfig -- the Typescript client is 'typescript' rather than 'tsserver'. This PR updates the rename-file functionality, which seems to be the only place that explicitly looks for the server, to consider 'typescript' as well as 'tsserver'.

jose-elias-alvarez commented 2 years ago

This is a simple change to make here, but is there a specific reason why lspinstall uses typescript instead of tsserver? If not, I feel like it makes sense to change the client name on their end to be consistent with lspconfig.

jason0x43 commented 2 years ago

lspinstall uses the language name for lsp configs rather than the server name. I believe it's primarily for ease of use (LspInstall typescript or LspInstall lua are more intuitive than LspInstall tsserver or LspInstall sumneko) and consistency with other editors such as VS Code.

jose-elias-alvarez commented 2 years ago

I see, that's reasonable then. Thanks for the fix!