josealejandro2928 / react-image-picker-editor

React library for the selection, edition and compression of images in png, jpeg and webp formats This package is made completely with html and css without any extra components or npm packages. It's based in functional components based in hooks, for optimization were used memo, useMemo and useCalback for avoiding any extra-renders.
https://www.npmjs.com/package/react-image-picker-editor
MIT License
26 stars 18 forks source link

Version 1.3.4 has dependency on react 17 #15

Open ericwhitlock opened 1 month ago

ericwhitlock commented 1 month ago

Hi Jose. Great library. Thanks for your efforts on it.

I am running react 18.2.0 and saw that version 1.3.4 of your library shows "Ready to React 18" at https://www.npmjs.com/package/react-image-picker-editor but after running npm i I ran into the following error:

Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from react-image-picker-editor@1.3.4
npm ERR! node_modules/react-image-picker-editor
npm ERR!   react-image-picker-editor@"^1.3.4" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@"^17.0.2" from react-image-picker-editor@1.3.4
npm ERR!   node_modules/react-image-picker-editor
npm ERR!     react-image-picker-editor@"^1.3.4" from the root project

Is this due to your package.json below or am I doing something wrong? https://github.com/josealejandro2928/react-image-picker-editor/blob/6a9f18ca950b7d908c7667d7aa8fc762a8fb21ab/package.json#L30-L32

josealejandro2928 commented 1 month ago

Yep, maybe is an issue the declarative way of the package Json. Try npm i --force

On Sat, Jun 1, 2024, 4:59 PM Eric Whitlock @.***> wrote:

Hi Jose. Great library. Thanks for your efforts on it.

I am running react 18.2.0 and saw that version 1.3.4 of your library shows "Ready to React 18" at https://www.npmjs.com/package/react-image-picker-editor but after running npm i I ran into the following error:

Could not resolve dependency: npm ERR! peer react@"^17.0.2" from @. npm ERR! node_modules/react-image-picker-editor npm ERR! react-image-picker-editor@"^1.3.4" from the root project npm ERR! npm ERR! Conflicting peer dependency: @. npm ERR! node_modules/react npm ERR! peer react@"^17.0.2" from @.*** npm ERR! node_modules/react-image-picker-editor npm ERR! react-image-picker-editor@"^1.3.4" from the root project

Is this due to your package.json below or am I doing something wrong? https://github.com/josealejandro2928/react-image-picker-editor/blob/6a9f18ca950b7d908c7667d7aa8fc762a8fb21ab/package.json#L30-L32

— Reply to this email directly, view it on GitHub https://github.com/josealejandro2928/react-image-picker-editor/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2QHWJR6B4ERLZE3NHWR4LZFHOUJAVCNFSM6AAAAABIUG7QHWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDSMJYGY4TCMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>