Closed mdarmstr closed 11 months ago
Agreed
El jue, 14 sept 2023 14:55, Michael D. Sorochan Armstrong < @.***> escribió:
Hi Pepe, I have synced the changes from version 2 of the MEDA toolbox with my own working repository. My suggestion is to include colourblind friendly colours by default, according to a commonly referenced standard. As long as there are under 8 different labels, this should be okay. Let me know what you think either way.
You can view, comment on, or merge this pull request online at:
https://github.com/josecamachop/MEDA-Toolbox/pull/63 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z25Go4ypXQ$ Commit Summary
- b08e7c1 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/b08e7c1366908d3508b6edee1825fad157094dfc__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z242JjPfCw$ Merge pull request #8 from josecamachop/master
- 8983836 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/8983836ae34dca3992661391fd7596f6102512aa__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z27FJUJWNA$ Update simuleMV.m
- e18fdd4 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/e18fdd448703517f661b3da5124fcc3c0dfd3d30__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z273RJYDsw$ Update biplot.m
- 8f08804 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/8f088045b85f4cb86f6f8142550923fe933c5015__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z26MeoO0xA$ Update gasca.m
- bf4be8a https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/bf4be8ace01af5d6aac4494f7bc6a93b4b3bd4ac__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z25X_swpAA$ changing colours
- 6891201 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/68912010e673176a084783d475a396d09389ffdf__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z27twZCDPw$ Merge branch 'josecamachop:master' into master
- b660001 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/b6600011205ea4aa0f8ef6427e68352caedbd477__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z26B4iwxlQ$ trying to fix bad pull request
- 0c79a20 https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/0c79a205edad25e6fe40258ee45829b02c26de15__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z250du6Zsg$ Merge pull request #9 from mdarmstr/main
- ed5f83e https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/commits/ed5f83e6b082e3531b48e4dbc120c6453235f731__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z25Wa6A3Rw$ Merge pull request #10 from josecamachop/version-2
File Changes
- M biplot.m https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/files*diff-67192215efe45b0530391b584a961f17c1764f88fda39f88540aeeb6e6cde905__;Iw!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z27ko0zBPg$ (12)
- M gasca.m https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/files*diff-5fcc0e70ad42d8515b742c324535c0fd3cb9f39ab7303937d820c068830294ec__;Iw!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z24cRXFP_g$ (43)
- M plot_scatter.m https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/files*diff-4f25b8622423f9521cb326e789aad6e441bf8004096f8e77e923acc01b3e322b__;Iw!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z24wc4hxtA$ (15)
- M plot_vec.m https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/files*diff-cbd3301eeb1bf6fb083ada807daec67b8bd4a157bd3bf0fa5b55e1be0cf56a0b__;Iw!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z258crq3nw$ (25)
- M simuleMV.m https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63/files*diff-729110977a3c13faab050746e697c04509b2bbc3cdc32c7cef4bb61d69ff8db0__;Iw!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z27ceVfidA$ (10)
Patch Links:
- https://github.com/josecamachop/MEDA-Toolbox/pull/63.patch https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63.patch__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z27kB517uA$
- https://github.com/josecamachop/MEDA-Toolbox/pull/63.diff https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63.diff__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z25jcSwqqg$
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/josecamachop/MEDA-Toolbox/pull/63__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z25Go4ypXQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB6T7LCIHTHUVXBKKF4I3Z3X2L5DJANCNFSM6AAAAAA4YB6ZYA__;!!D9dNQwwGXtA!UUMWpqcrpN5SKIt_G-uw1WkGNKDuWnUBvtxwsB_HKvPrFaoIsOAx38-lUH4Y8UUnJQsske5b5UfaXuA7z24lo7AcgA$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi Pepe, I have synced the changes from version 2 of the MEDA toolbox with my own working repository. My suggestion is to include colourblind friendly colours by default, according to a commonly referenced standard. As long as there are under 8 different labels, this should be okay. Let me know what you think either way.