search

josefadamcik / SofleKeyboard

A split keyboard based on Lily58, Crkbd and Helix keyboards
https://josefadamcik.github.io/SofleKeyboard/
Other
1.94k stars 290 forks source link

include 3D printable case(v1) #115

Closed Canorus closed 2 years ago

Canorus commented 3 years ago

I was asked to share my 3D printable sofle keyboard case on IG. When I decided to share my model, I realized v2 was launched and not compatible with v1. Since my model is based on v1, I can understand if you reject this pr.

STL files and gcode files are under /Sofle_v1/Case/3D Print/

josefadamcik commented 3 years ago

Thanks for the contribution! Sofle v1 is still a valid design and there are people who actually prefer the first version. So the case design is certainly appreciated. I'll look into it later in detail and merge it to the master assuming everything is fine.

`

Canorus commented 3 years ago

I am so sorry for wasting your time. I removed .gcode files and added missing actual case .stl files.

While I was exporting the 3d model, I realized that the case was designed to fit modified version of SofleKeyboard that replaced TRRS connector to USB4085 receptacle instead of the original SofleKeyboard. Not that it will block the TRRS cable or anything but it may look awkward in a way. I'll try to update the design when I can.

josefadamcik commented 3 years ago

@Canorus

I am so sorry for wasting your time. I removed .gcode files and added missing actual case .stl files.

Thanks and don't worry :)

I realized that the case was designed to fit modified version of SofleKeyboard that replaced TRRS connector to USB4085 receptacle instead of the original SofleKeyboard. Not that it will block the TRRS cable or anything but it may look awkward in a way. I'll try to update the design when I can.

I think it would be better if it was adjusted for the original design if it's going to be in the main repository. If you adjust the case, I'll accept the PR.

That said, you don't have to do any modification if you don't want. I think it would be perfectly fine to put the STL files in Thingiverse or similar, put some description to it and people will find it when they search for "sofle case". There are few 3d printed cases there already and there is no big need to have the case in the main repository.

Canorus commented 3 years ago

I think it would be better if it was adjusted for the original design if it's going to be in the main repository.

That was what I was thinking. I managed to find some time to make the adjustment and fortunately there wasn't much to be done. Now the case fits to original design.

I think it would be perfectly fine to put the STL files in Thingiverse or similar, put some description to it and people will find it when they search for "sofle case".

I thought about that too, but then I would have to include modified pcb too. I thought it'd be better just to contribute to the original repo if that's the case.

Anyway, I was glad I could contribute. Sofle Keyboard was my first split keyboard and first custom-ish keyboard. Please check when it's convenient for you.