search

josefadamcik / SofleKeyboard

A split keyboard based on Lily58, Crkbd and Helix keyboards
https://josefadamcik.github.io/SofleKeyboard/
Other
1.94k stars 290 forks source link

Add VIA support for Sofle Choc #194

Closed JellyTitan closed 4 months ago

JellyTitan commented 10 months ago

I'd like to add VIA support for the Sofle Choc. Since there's already a via folder on the QMK side, the config on the VIA side needs to be added. I didn't see any open PR's, so I went ahead and submitted one for the Sofle Choc: https://github.com/the-via/keyboards/pull/2139 All PR's are paused on VIA for December/January, so it'll sit for a bit.

JellyTitan commented 9 months ago

The VIA PR is blocked because in the QMK branch the Product ID and the VendorID are the same as the Sofle rev1. image

@brianlow do you mind if i put in a PR with QMK to make it unique?

brianlow commented 9 months ago

@JellyTitan go for it!

JellyTitan commented 4 months ago

The PR for the vid/pid choc was closed and moved to a new PR. (Same code). https://github.com/qmk/qmk_firmware/pull/24030

JellyTitan commented 4 months ago

@brianlow The PR to make the Sofle Choc VID/PID unique has been approved and merged into QMK master. The VIA PR has been updated.

brianlow commented 4 months ago

Great, let me know if you need anything

JellyTitan commented 4 months ago

VIA support has been approved and merged. @brianlow is documentation support warranted?

brianlow commented 4 months ago

Up to you