search

josefarias / hotwire_combobox

An accessible autocomplete for Ruby on Rails.
https://hotwirecombobox.com
MIT License
436 stars 26 forks source link

Add background color to group label #122

Closed ocarreterom closed 4 months ago

ocarreterom commented 4 months ago

Add a background color to .hw-combobox__group__label following .hw-combobox__option style.

I wonder if it's worth adding the background color to .hw-combobox__listbox like Bootstrap does. https://github.com/twbs/bootstrap/blob/v5.3.3/scss/_dropdown.scss#L59

josefarias commented 4 months ago

Great catch! Thanks!

I think it might be enough to have the bg color on the options and group labels themselves. Could've probably done it at the listbox level, too. But I don't think we need to do both.

Anyway, food for thought for a possible simplification. I see no reason not to merge this for now though.