search

josefarias / hotwire_combobox

An accessible autocomplete for Ruby on Rails.
https://hotwirecombobox.com
MIT License
436 stars 26 forks source link

open listbox only if it contains options #179

Open robinboening opened 1 month ago

robinboening commented 1 month ago

In case the listbox doesn't have any options it doesn't need to be shown. See this discussion for reference: https://github.com/josefarias/hotwire_combobox/discussions/178

robinboening commented 1 month ago

@josefarias I wasn't comfortable touching the tests as I am not familiar enough with the setup and all the helpers. Would you mind giving me a hand if you think this should be tested?