search

josefnpat / vapor

Vapor - LÖVE Distribution Client
zlib License
77 stars 24 forks source link

Find suitable hash algorithm implementation in pure Lua #194

Open josefnpat opened 9 years ago

josefnpat commented 9 years ago

I am looking for a stable and fast Lua lib with a version of SHA.

SHA1, SHA256 or SHA512 would be best, imo. The higher, the better, assuming that the performance isn't miserable.

A good candidate (which was used in vapor0.x): https://bitbucket.org/Boolsheet/bslf

@Positive07 says he will research this topic :smile:

pablomayobre commented 9 years ago

Okey fine if you ask me that kindly :laughing:

josefnpat commented 9 years ago

@Positive07 thanks!

pablomayobre commented 9 years ago

Well I have a SHA-256 working, gonna investigate for SHA-512 now

EDIT: Well actually later, have things to do right now :disappointed:

pablomayobre commented 9 years ago

Why didnt you use SHA-256 when it is already in hash.lua @josefnpat ?

SHA-512 requires 64bits, so I'll need to use something like this, the algorithm itself is pretty much the same as SHA-256, so after I implement that I will test them all.

Another note: Boolsheet's and the hash library have a loading overhead, after that they are pretty darn fast, so it is recommend it to load it once, but the current hashing system creates a thread whenever there is a need for hashing, it may be better to have a thread that is constantly waiting for messages, and hashes whatever it gets (basically to put a loop in the thread), just an idea.

Bobbyjoness commented 9 years ago

I like that idea but we would have to handle errors with the thread and kinda have thread management figured out.

pablomayobre commented 9 years ago

That is pretty simple anyway, I can provide a code for that, tomorrow or tonight really late :stuck_out_tongue_closed_eyes: