josefprusa / Prusa3

Prusa iteration3
Other
839 stars 523 forks source link

X-axis mirroring is incomplete #60

Closed darrenfreeman closed 11 years ago

darrenfreeman commented 11 years ago

Firstly, I don't like that the x-ends have been mirrored, as I've laid out the cables already :/ But I'm sure there are people who like it, so please make this a configuration option.

For the mirrored version, as it currently stands, you don't mirror the x-idler. The nut trap is now visible from the front of the machine, so please mirror all three parts to return the nut trap to the rear where it belongs.

I can fix this in my local copy, but it will affect others, so please keep it in mind for the next time you're doing a commit. It's an easy fix.

jglauche commented 11 years ago

Why would you want th e x-axis to be mirrored? The box frame parts come out correctly aligned. Smooth side to the front, nut traps to the top.

darrenfreeman commented 11 years ago

I'm not talking about the x-carriage. I'm clearly talking about the x-ends. If you look in the code, it is mirrored down at the bottom of the file.

AxTheB commented 11 years ago

x-ends are mirrored so when the smooth sides are in the front and stepper to the left (which is default configuration), the nut traps are on top.

AxTheB commented 11 years ago

I fixed complete-printer-plus.scad to show the change.

darrenfreeman commented 11 years ago

I had to look at complete-printer-plus.scad to figure out what you were saying :)

So why was this change made? Many printers don't produce a smooth side, they produce an ugly side. And even though mine are smooth, I think the rounded side looks much better facing up.

I still think you should include this as a configuration option to go back to how things were, by turning off the mirroring.

AxTheB commented 11 years ago

The nut traps should be on top to prevent Z threaded rod binding when the x-ends and steppers are not perfectly aligned. The change was so we have more space around extruder for experiments

AxTheB commented 11 years ago

And its needed for printers with 10 or 12mm smooth rods

jglauche commented 11 years ago

This doesn't need a configuration option. If you want, you can always use a previous version with git.

We sometimes need to break the old ways, like happened here. Sorry if you need to rewire your machine to adapt the new way.

AxTheB commented 11 years ago

The mirroring does not need any rewiring as all components with wires are in the same place. Both parts are mirrored in the right way.

darrenfreeman commented 11 years ago

When you mirrored the parts, you didn't explain why.. anywhere. So my motor is on the right.

But I designed the wiring layout for the motor to be on the left, so the updated complete-printer-plus.scad fixes it for me.

I think you need to keep this file up-to-date with every commit, as when I started my build there was a near complete absence of documentation. It's still not very clear to a newcomer what they are supposed to be doing.

AxTheB commented 11 years ago

Good thing that turning the axis around so the stepper is on the right and nuts on top is three minute job ;)

darrenfreeman commented 11 years ago

The idler tensioner is still not mirrored, so that it is installed shiny side down into parts that are shiny side up.

darrenfreeman commented 11 years ago

I don't have access to reopen this issue, so I may have to create a new one if people don't notice the above post. I think it would be better not to close issues so quickly without testing the fix. In this case, a version was committed without an idler tensioner at all, and at that time the issue was closed.

AxTheB commented 11 years ago

Just turn it around by hand, its not stereospecific. The idler was missing because I was testing updated pushfit module, did not want to waste plastic and forgot to uncomment. Please let this isue sleep, it does not really exist.

darrenfreeman commented 11 years ago

I posted a comment, and it has gone away. The idler tensioner is not equal to its mirror image. One side has a visible nut trap, the other doesn't. But one side is shiny and the other is not. So unless you also mirror the idler, the end user has to choose between the shiny side facing down when inserted into a part with the shiny side facing up, or the nut trap visible from the front when it's uglier and not drawn that way in the complete printer.