search

josegonzalez / app

CakePHP3: a composer project skeleton for the FUTURE
8 stars 7 forks source link

Updated composer.json to to fix errors on PHP 7.2 #10

Closed justinhartman closed 6 years ago

justinhartman commented 6 years ago

As per this bug using friendsofcake/crud version 4 returns a fatal error when using PHP 7.2. The fix is to set the friendsofcake/crud to version 5.

josegonzalez commented 6 years ago

Thanks for the pull request!

justinhartman commented 6 years ago

Absolute pleasure. I came across something else. I noticed that vendor/bin/heroku-php-nginx doesn't exist in the project and I wanted to ask if there was a particular reason you didn't include "heroku/heroku-buildpack-php" in composer.json?

If I add "heroku/heroku-buildpack-php": "^134.0" or run $ composer require heroku/heroku-buildpack-php it solves my issue of linking nginx and if this was omitted in error I'll happy do another PR.

josegonzalez commented 6 years ago

Thats for when you deploy on heroku with a buildpack. I don't include it otherwise.