Closed justinhartman closed 6 years ago
Thanks for the pull request!
Absolute pleasure.
I came across something else. I noticed that vendor/bin/heroku-php-nginx
doesn't exist in the project and I wanted to ask if there was a particular reason you didn't include "heroku/heroku-buildpack-php"
in composer.json
?
If I add "heroku/heroku-buildpack-php": "^134.0"
or run $ composer require heroku/heroku-buildpack-php
it solves my issue of linking nginx
and if this was omitted in error I'll happy do another PR.
Thats for when you deploy on heroku with a buildpack. I don't include it otherwise.
As per this bug using
friendsofcake/crud
version 4 returns a fatal error when using PHP 7.2. The fix is to set thefriendsofcake/crud
to version 5.