search

josegonzalez / app

CakePHP3: a composer project skeleton for the FUTURE
8 stars 7 forks source link

Q: Is app.php really meant to be in .gitignore? #3

Closed HarderWork closed 7 years ago

HarderWork commented 7 years ago

/config/app.php in .gitignore makes sense (I guess) when developing the app skeleton, but it should be changed when I use "composer create project" for my project.

This is inherited from "original" app skeleton: https://github.com/cakephp/app/blob/master/.gitignore

josegonzalez commented 7 years ago

That comes from upstream CakePHP/app.

I still gitignore it because not doing so encourages devs to commit it with secrets, whereas the default implies no secrets.

All clones/install of the app call the installer for me, which in this skeleton just uses env vars so everything works fine.