search

josegonzalez / cakephp-queuesadilla

CakePHP3: easily run background jobs on various message backends
https://cakephp-queuesadilla.readthedocs.org/en/latest/
MIT License
34 stars 14 forks source link

Queue::reset() should reset internal queue objects #26

Closed asaliev closed 5 years ago

asaliev commented 5 years ago

Attempt at #25

Note: on local install composer pulled cakephp 3.7 for me and a bunch of deprecated errors started popping up, so locally I've used error_reporting(E_ALL & ~E_USER_DEPRECATED); to run the tests.

josegonzalez commented 5 years ago

Mind taking a stab at fixing the coveralls requirement?

asaliev commented 5 years ago

Aight I'll check it, but I think I'll need to update travis config too, since it attempts to get fetch the dev-master package

josegonzalez commented 5 years ago

Sounds good to me :)

asaliev commented 5 years ago

@josegonzalez looks like only the deprecated stuff is left. do we want to do this in this PR? This will probably mean bumping the cakephp/cakephp version constraint tho

josegonzalez commented 5 years ago

I'll merge this for now, but can you make a pr for the deprecations? I'll make a release after that :)

asaliev commented 5 years ago

I'll merge this for now, but can you make a pr for the deprecations? I'll make a release after that :)

@josegonzalez I'll take a look, sure

Sent with GitHawk