Enhance table/associations handling

josegonzalez / cakephp-version

CakePHP3: plugin that facilitates versioned database entities

MIT License

51 stars 22 forks source link

Enhance table/associations handling #17

Closed robertpustulka closed 7 years ago

robertpustulka commented 7 years ago

This PR provides several enhancements:

an ability to set referenceName (just like in the core ~Tree~ Translate behavior), table alias isn't always a good discriminator (it fails when a table is loaded several times using different aliases)
association handling overhaul: the idea behind versionTable config was rather unclear (sometimes used as a db table, sometimes as a TableRegistry key and sometimes as an associaciot name); now it's used to describe ORM table used to store versions.
public accessor for version associations: both "global" versions association and individual "per-field" associations
versions are hydrated using source table entityClass rather than the core Entity

coveralls commented 7 years ago

Coverage increased (+0.8%) to 91.667% when pulling 0bb8a0c5bc7512e16f33fe93a9c7055bbcd6f5a8 on robertpustulka:better-table into 47f796e2df9b6092813eec82da83f0a9769b18ed on josegonzalez:master.

josegonzalez commented 7 years ago

Minor PHPCS issues.

coveralls commented 7 years ago

Coverage increased (+0.8%) to 91.667% when pulling 44e8fb20a67d068420df625f5c73c69c407d340f on robertpustulka:better-table into 47f796e2df9b6092813eec82da83f0a9769b18ed on josegonzalez:master.

robertpustulka commented 7 years ago

@josegonzalez fixed and passing

josegonzalez commented 7 years ago

Can you add docs for the new features?

robertpustulka commented 7 years ago

I'm not sure that internal association handling is that important to be documented (anybody could read the code if they're interested in that) but I've added referenceName to the Configuration section.

coveralls commented 7 years ago

Coverage increased (+0.8%) to 91.667% when pulling 0fbd6b380b03dee5b009f4520b87738dc3b7ec9d on robertpustulka:better-table into 47f796e2df9b6092813eec82da83f0a9769b18ed on josegonzalez:master.