search

josegonzalez / cakephp-version

CakePHP3: plugin that facilitates versioned database entities
MIT License
51 stars 22 forks source link

Fix additional data coming from right table. #27

Closed dereuromark closed 7 years ago

dereuromark commented 7 years ago

We must read the created/user_id from the correct table, in this case the versions one.

Now a versions dropdown can actually display the additional meta data:

<option value="6">6 (3/19/17, 9:30 PM by uid 2)</option>
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling d1022ad42981a210199a9dd47bc8d9ce7222c397 on dereuromark:master-bugfix into 3c69b8ec31e925fda289df2473127f6a179e1630 on josegonzalez:master.

josegonzalez commented 7 years ago

Tests?

dereuromark commented 7 years ago

There are some, they just didnt check the exact datetime value. Feel free to post add a few more.

PS: Is there a version release planned? Thx

josegonzalez commented 7 years ago

I'll merge/release when you add a test proving that the previous functionality didn't work.

dereuromark commented 7 years ago

Yeah, in order to prevent regression it is safer to add a test case. I also asserted on the value itself.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling 5b95c0e0837183a0380b6dd4f0db44cd5c802314 on dereuromark:master-bugfix into 3c69b8ec31e925fda289df2473127f6a179e1630 on josegonzalez:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 91.954% when pulling 5b95c0e0837183a0380b6dd4f0db44cd5c802314 on dereuromark:master-bugfix into 3c69b8ec31e925fda289df2473127f6a179e1630 on josegonzalez:master.

josegonzalez commented 7 years ago

Released.