search

josegonzalez / cakephp-version

CakePHP3: plugin that facilitates versioned database entities
MIT License
51 stars 22 forks source link

[RFC] Added typing support #36

Closed jeremyharris closed 6 years ago

jeremyharris commented 6 years ago

Adds type support to versions. You can now save versions that have fields with non scalar types, and all version entities now respect the field's type.

chris48s commented 6 years ago

Will leave maintainer to review, but quick drive-by comment:

In order to get those Postgres builds to pass, you'll need to run them against version 9.4 or above for jsonb support (Travis CI uses version 9.1 by default ). You can do that by adding

addons:
  postgresql: "9.4"

to .travis.yml.

jeremyharris commented 6 years ago

Thanks @chris48s, I added it to the travis yaml. If José wants, we can remove that change and I can add a skip to the test case if it's in the postgresql build.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+3.03%) to 78.634% when pulling 2f55cb82d19101f0046b1e2b33ea8167c9437a10 on jeremyharris:types into 9805605e293815bc52bf94edf1f0fd43ddafada8 on josegonzalez:master.

jeremyharris commented 6 years ago

ping

jeremyharris commented 6 years ago

Thanks a bunch!