search

josegonzalez / cakephp-version

CakePHP3: plugin that facilitates versioned database entities
MIT License
51 stars 22 forks source link

Remove EntityTrait::unsetProperty deprecation #41

Closed GrantAnt closed 3 years ago

GrantAnt commented 3 years ago

Replace EntityTrait::unset with EntityTrait::unsetProperty

Currently when executing the tests the following Log is written:

Deprecated Error: EntityTrait::unsetProperty() is deprecated. Use unset() instead. - C:\code\xampp\htdocs\CRM_doxx\vendor\josegonzalez\cakephp-version\src\Model\Behavior\VersionBehavior.php, line: 236 You can disable all deprecation warnings by setting Error.errorLevel to E_ALL & ~E_USER_DEPRECATED, or add vendor/josegonzalez/cakephp-version/src/Model/Behavior/VersionBehavior.php to Error.ignoredDeprecationPaths in your config/app.php to mute deprecations from only this file. In [C:\code\xampp\htdocs\CRM_doxx\vendor\cakephp\cakephp\src\Core\functions.php, line 316]

josegonzalez commented 3 years ago

Do tests fail because of this PR?

jeremyharris commented 3 years ago

Nah the test failing is another change from cake I think. I can PR a fix for that particular test later.