search

josegonzalez / cakephp-version

CakePHP3: plugin that facilitates versioned database entities
MIT License
51 stars 22 forks source link

Fixed EventListener compatibility with cakephp 4.x #44

Closed jeremyharris closed 3 years ago

jeremyharris commented 3 years ago

Fixes #42

josegonzalez commented 3 years ago

Should I move this to friendsofcake? I don't maintain this anymore :(

jeremyharris commented 3 years ago

It's up to you man :) I understand not being able to maintain this anymore.

If they require a green build to take it on then this PR + https://github.com/josegonzalez/cakephp-version/pull/41 + one more PR to fix the test (I think cake 4 changed how it indexed associations) should fix it all up. I can PR that other one too.

The deprecations don't really matter yet but this bug prevents using the plugin.

josegonzalez commented 3 years ago

@jeremyharris mind filing another PR to fix tests?

jeremyharris commented 3 years ago

@josegonzalez yeah no problem