josegonzalez / dokku-global-cert

allows setting a global certificate for applications
MIT License
20 stars 6 forks source link

support multiple global certs applied per vhost #6

Open AubreyHewes opened 3 years ago

AubreyHewes commented 3 years ago

Well this maybe out of scope or more a feature request..

but imagine you want to deploy apps as *.app.domain.tld and services as *.service.domain.tld. You would want two global certs applied to matching vhosts...

Proposal is that you can do global-cert:set (set the default global cert for all apps; current behaviour), but also global-cert:set <crt> <key> <wildcard-domain>. Adds a global cert for that domain.

i.e.

Add a global cert for *.app.domain.tld (default behaviour). Then if an app is deployed as myapp.app.domain.tld it will use *.app.domain.tld global cert...

Add a secondary global cert for *.service.domain.tld. Then if an app is deployed as myservice.service.domain.tld it will use *.service.domain.tld global cert...

This is something that if I ever get time for I may work out / PR, but thought it may be relevant to issue it.