search

josejimenezluna / pyGPGO

Bayesian optimization for Python
http://pygpgo.readthedocs.io
MIT License
240 stars 61 forks source link

[JOSS]: Test coverage #8

Closed dfm closed 6 years ago

dfm commented 7 years ago

Another comment for the JOSS review: openjournals/joss-reviews#41

I'm a bit concerned about the test coverage. There are tests that are being run on Travis (this is great!) but, as far as I can tell, only three different options are being tested even though many options seem to be available. I'd love to see the coverage report and it might be worth putting some thought into a broader test suite.

josejimenezluna commented 7 years ago

Thanks for your useful comments.

More unit tests have been included under the tests folder. They extensively cover:

Integration tests are taken care of by test_GPGO. While it is certainly very difficult to cover every single different combination of choices, this should give a much better starting point.

Code coverage is now computed in the Travis build as well, and a badge is available on the README.md file.

Let me know if I can close this.

dfm commented 7 years ago

Looks good but, if you look at the coverage report, it looks like only the test coverage is counted. Make sure that you're actually measuring coverage across the module.

Also: it looks like you've added the dist and *.egg-info directories to the repo - you probably didn't mean to do that!

josejimenezluna commented 7 years ago

Whoops, my fault.

I'm having some issues with Travis and pytest-cov reporting different estimates than a local installation. In the meantime I'm uploading the latter so that you can check.

dfm commented 6 years ago

Great! This looks better now.