joselcvarela / ng2-carouselamos

Simple carousel/slider for angular 2.
40 stars 35 forks source link

Last item in carousel throws an error #6

Closed limpep closed 7 years ago

limpep commented 7 years ago

@joselcvarela Hi,

When I scroll to the last item in the carousel I am getting the following error, ExpressionChangedAfterItHasBeenCheckedError

Here is the full stack trace,

core.es5.js:8418 Uncaught Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'false'. Current value: 'true'.
    at viewDebugError (core.es5.js:8418)
    at expressionChangedAfterItHasBeenCheckedError (core.es5.js:8396)
    at checkBindingNoChanges (core.es5.js:8560)
    at checkNoChangesNodeInline (core.es5.js:12421)
    at checkNoChangesNode (core.es5.js:12395)
    at debugCheckNoChangesNode (core.es5.js:13172)
    at debugCheckRenderNodeFn (core.es5.js:13112)
    at Object.eval [as updateRenderer] (Ng2Carouselamos.html:74)
    at Object.debugUpdateRenderer [as updateRenderer] (core.es5.js:13094)
    at checkNoChangesView (core.es5.js:12217)

using version, "ng2-carouselamos": "^2.4.4"

limpep commented 7 years ago

Also the carousel doesn't seem to work at all on mobile. Thanks

ghost commented 7 years ago

omg, i lost 2 hours in the work trying to config with this package. and i have error in the last item

ghost commented 7 years ago

I have the same error, I'm using angular-seed but I did a test using angular-cli and works just fine

joselcvarela commented 7 years ago

Hey everybody, I refactor this package considering this repo. Can you check if this error happens with the latest version? It's working fine for me

limpep commented 7 years ago

@joselcvarela manage to test with

    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.4.2
node: 8.1.2
os: win32 x64
@angular/animations: 4.4.3
@angular/common: 4.4.3
@angular/compiler: 4.4.3
@angular/core: 4.4.3
@angular/forms: 4.4.3
@angular/http: 4.4.3
@angular/platform-browser: 4.4.3
@angular/platform-browser-dynamic: 4.4.3
@angular/router: 4.4.3
@angular/cli: 1.4.2
@angular/compiler-cli: 4.4.3
@angular/language-service: 4.4.3
typescript: 2.5.2

and "ng2-carouselamos": "^3.2.0", and its all working fine

joselcvarela commented 7 years ago

Nice 👍 I am closing this issue for now, but you can reopen if you have this bug on future.