joselfonseca / lighthouse-graphql-passport-auth

Add GraphQL mutations to get tokens from passport for https://lighthouse-php.com/
https://lighthouse-php-auth.com/
MIT License
231 stars 55 forks source link

Please add support for passport v10 #108

Closed stephenjason89 closed 4 years ago

stephenjason89 commented 4 years ago

I'm currently upgrading to laravel 8 and it would be nice if this include support for passport 10 and socialite 5.0

thank you

joselfonseca commented 4 years ago

hey there @stephenjason89, it is in my radar, Laravel 8 just came out and we are not upgrading our apps yet, we are planning to add the support for this on 5.0 which is the next release scheduled for the 18th.

PRs are welcome!

stephenjason89 commented 4 years ago

Thank you for the update. Will try to do a PR once it is released.

side note: is multiple social account integration per user gonna be included? using socialLogin, it only assigns 1 provider per user.

What I did on my end was to create another table social_accounts and made it (belongsTo a user) (user hasMany social_accounts)

joselfonseca commented 4 years ago

Need to wait for https://github.com/nuwave/lighthouse to add Laravel 8 support before we can upgrade.

stephenjason89 commented 4 years ago

Thank you :)

joselfonseca commented 4 years ago

I re open the issue for tracking purposes and to keep the reminder to update.

https://github.com/nuwave/lighthouse/issues/1556

joselfonseca commented 4 years ago
Screen Shot 2020-09-23 at 9 26 42 AM

It will be harder than I thought

joselfonseca commented 4 years ago

I will wait for a stable 5.0 release https://github.com/nuwave/lighthouse/releases