search

joselfonseca / lighthouse-graphql-passport-auth

Add GraphQL mutations to get tokens from passport for https://lighthouse-php.com/
https://lighthouse-php-auth.com/
MIT License
229 stars 56 forks source link

Add Laravel 8 support #116

Closed daniel-de-wit closed 3 years ago

joselfonseca commented 3 years ago

Thanks for the PR. Unfortunately travis is failing

https://travis-ci.org/github/joselfonseca/lighthouse-graphql-passport-auth/builds/734269550

I've tried this before but there is a lot to fix when using the version 5 of lighthouse so that is why I haven't completed it.

https://github.com/joselfonseca/lighthouse-graphql-passport-auth/issues/108

joselfonseca commented 3 years ago

I think you could do this.

"require": {
        "php": ">=7.2.0",
        "nuwave/lighthouse": "^4.0",
        "laravel/passport": "^10.0",
        "laravel/socialite": "^5.0",
        "laravel/ui": "^3.0",
        "laravel/legacy-factories": "^1.0"
    },
    "require-dev": {
        "phpunit/phpunit" : "^9.0",
        "orchestra/testbench": "^6.0"
    },

That way is not failing for me. Let me know if you want to update the PR so your contribution gets merged.

joselfonseca commented 3 years ago

Fix #108

daniel-de-wit commented 3 years ago

Thanks for the PR. Unfortunately travis is failing

https://travis-ci.org/github/joselfonseca/lighthouse-graphql-passport-auth/builds/734269550

I've tried this before but there is a lot to fix when using the version 5 of lighthouse so that is why I haven't completed it.

108

Yeah, I saw your work before :)

Lucky for us lighthouse released 4.17 so that was my reason for sending this merge request. Thanks for fixing it with laravel/legacy-factories 👍

joselfonseca commented 3 years ago

yeah, Thank you for the PR!. Version 5.1 should work on Laravel 8 now.