search

joselfonseca / lighthouse-graphql-passport-auth

Add GraphQL mutations to get tokens from passport for https://lighthouse-php.com/
https://lighthouse-php-auth.com/
MIT License
228 stars 56 forks source link

Use Auth Provider of Passport client. #158

Closed merbhushan closed 1 year ago

merbhushan commented 1 year ago

In existing code, we can't use any other provider apart from users but laravel passport allow us to use different provider. I modified a logic to give support of laravel passport provider and we can also configure a default provider inside configuration file.

joselfonseca commented 1 year ago

Thanks for the PR. Looks like the CI is failing and also the code style https://github.styleci.io/analyses/PGmMEL?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

If you can fix that I can review again and merge.

merbhushan commented 1 year ago

Hello @joselfonseca

I noticed inside lighthouse php package(nuwave/lighthouse), they moved AuthDirective to separate folder but it's namespace is not being registered and because of that it started giving auth directive not found error. It's moved in 5.70 version. Can you please run a workflow for existing master branch, I think it should give a same errors?

merbhushan commented 1 year ago

@joselfonseca I added a fix for failing test cases. Can you please review it and merge it.

joselfonseca commented 1 year ago

@merbhushan looks like the test are good now, you only need to fix the style ci error and we can merge and release.

merbhushan commented 1 year ago

@joselfonseca Please check now.

joselfonseca commented 1 year ago

@merbhushan https://github.com/joselfonseca/lighthouse-graphql-passport-auth/releases/tag/7.0.0