joselfonseca / lighthouse-graphql-passport-auth

Add GraphQL mutations to get tokens from passport for https://lighthouse-php.com/
https://lighthouse-php-auth.com/
MIT License
228 stars 56 forks source link

Laravel 10 and PHP Lighthouse 6 support #164

Closed elendil1979 closed 1 year ago

elendil1979 commented 1 year ago

Hello,

Do you plan to add support for Laravel 10 and PHP Lighthouse 6? recently both are updated and if you apply this update this package has dependency issues.

Laravel 10 require "laravel/passport": "^11.0" and this addon require "laravel/passport: "^9.0"

This is the message from composer update

Problem 1

Thank you very much in advance

Hola,

¿tienes pensado agregar soporte para Laravel 10 y PHP Lighthouse 6? recientemente ambos están actualizados y si aplicas esta actualización, este paquete tiene problemas de dependencias

Parece que este paquete requiere "laravel/passport: "^9.0" mientras que Laravel 10 requiere "laravel/passport": "^11.0" y se produce un error en composer update

Muchas gracias de antemano

joselfonseca commented 1 year ago

I think that was added here https://github.com/joselfonseca/lighthouse-graphql-passport-auth/releases/tag/9.0.0 If we missed support for something else in version 9 then that would be an issue. We may need to have a specific issue for the package we missed.

Lo agregamos aca https://github.com/joselfonseca/lighthouse-graphql-passport-auth/releases/tag/9.0.0 Si olvidamos soporte a otro paquete en version 9 es un problema. Tendríamos que crear un issue especifico para lo que falta.

joselfonseca commented 1 year ago

@elendil1979 Please install version 9 and let us know if it works. https://github.com/joselfonseca/lighthouse-graphql-passport-auth/blob/master/composer.json#L21 It should.

elendil1979 commented 1 year ago

Perfect, work fine

Thanks