Closed DiskoPete closed 4 years ago
Also if we are making the user model from a factory, can that also be applied to the login ? right now the login also has methods to make or create the user class.
Correct. You got me here 😄
I was a bit short on time and didn't go for the extra mile. Will fix this.
@joselfonseca I addressed you feedback. Thanks for having another look.
🙂
hi @joselfonseca
Did you already had time to have another look at the pull request?
Cheers
@DiskoPete seems that the branch is out of date. Can you please update your branch and then i'll take a look.
Thanks.
@joselfonseca I updated the branch. Thanks!
Since I didn't want to make the
password
field fillable on my user model, I thought about having a similar approach to the default RegisterController.This will make it possible to extend the Register resolver and customize the model creation.
I expect no breaking change from this modification.
Looking forward to your feedback! 🙂 Thanks!