refactor(dockerfile): set shell options globally

[guoard]

This pull request aims to improve the consistency and reliability of Dockerfiles by introducing a global SHELL directive and setting options globally. Additionally, it introduces a new option, pipefail, to enhance error detection and prevent potential issues during the build process.

[joseluisq]

Please help me to understand your changes. Here are my concerns.

• Why ash and not bash?
• I'm wondering if using a global SHELL will not interfere when users want to extend this image. I mean, if -euxo pipefail options will not be applied by default. If so, then some users could run into more script strictness that I do not know users will want. Subsequently, did you think that if this could break existing Dockerfiles by some users?

[guoard]

1) By default Alpine Linux uses the busybox variant of the ash shell. you can check root user shell with this command:

docker run --rm alpine ash -c "cat /etc/passwd | grep root"

2) Yes, The -euxo pipefail options are commonly used for strict error handling and debugging in shell scripts. While they can be helpful, they may indeed introduce unexpected behavior for users who extend your image.

What are your thoughts on adding the following line into the Dockerfile to leverage the pipefail option:

SHELL ["/bin/ash", "-o", "pipefail", "-c"]

[joseluisq]

1. By default Alpine Linux uses the busybox variant of the ash shell. you can check root user shell with this command:

Yes, you are right. I just forgot it for a while when I was writing the previous comment. But just to be sure. Should be /bin/ash or /bin/sh? What I see everywhere is /bin/sh when using Alpine.

3. Yes, The -euxo pipefail options are commonly used for strict error handling and debugging in shell scripts. While they can be helpful, they may indeed introduce unexpected behavior for users who extend your image.

What are your thoughts on adding the following line into the Dockerfile to leverage the pipefail option:

SHELL ["/bin/ash", "-o", "pipefail", "-c"]

I do not you but I'm happy with having RUN set -euxo pipefail && ... per Docker RUN command and getting out of users' way.

[guoard]

But just to be sure. Should be /bin/ash or /bin/sh?

Yes, By default, both the BusyBox and Alpine Docker images include the Almquist Shell (/bin/ash). It's a lightweight fork of Bourne shell (/bin/sh) that aims to be minimal and fast.

I'm happy with having RUN set -euxo pipefail && ... per Docker RUN command and getting out of users' way.

Ok, I will try open another pull request.