search

josemarluedke / frontile

Component Library for Ember Octane apps
https://frontile.dev
MIT License
55 stars 21 forks source link

Modals broken with Ember v4 #175

Closed knownasilya closed 2 years ago

knownasilya commented 2 years ago 
Uncaught (in promise) Error: Invalid modifier manager compatibility specified
    at modifierCapabilities (manager.js:632)
    at focus-trap.js:10
    at CustomModifierManager.getDelegateFor (manager.js:681)
    at CustomModifierManager.create (manager.js:697)
    at Object.evaluate (runtime.js:2704)
    at AppendOpcodes.evaluate (runtime.js:1284)
    at LowLevelVM.evaluateSyscall (runtime.js:5064)
    at LowLevelVM.evaluateInner (runtime.js:5020)
    at LowLevelVM.evaluateOuter (runtime.js:5012)
    at VM.next (runtime.js:5981)
josemarluedke commented 2 years ago

Thanks for reporting it. It seems it is coming from focus-trap. I will have a look at it.

knownasilya commented 2 years ago

Was going to submit a PR tonight since you released focus-trap, but got this

error ember-focus-trap@1.0.0: The engine "node" is incompatible with this module. Expected version "12.* || >= 14". Got "10.13.0"

So probably not tonight.

josemarluedke commented 2 years ago

This has been fixed in the request PRs upgrading dependencies. Will release soon.