josemarluedke / glimmer-apollo

Ember and Glimmer integration for Apollo Client.
https://glimmer-apollo.com
MIT License
39 stars 15 forks source link

Resolve: #78 TVariables type now must extend from OperationVariable #79

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

Also resolves #76.

This is a breaking change because the TVariables type now must extend from OperationVariables, whereas before there was no constraint.

Because this library is pre 1.0, I think this is ok.

netlify[bot] commented 1 year ago

Deploy Preview for glimmer-apollo failed.

Name Link
Latest commit 9257cbc2faf22289bf93cc1c0df36b6586f4bf6f
Latest deploy log https://app.netlify.com/sites/glimmer-apollo/deploys/63dd462825c8cd0008103c5e
josemarluedke commented 1 year ago

@NullVoxPopuli Some TS tests are failing, would you take a look at these?

NullVoxPopuli commented 1 year ago

ah, looks like I forgot to build the package before checking types 😅 fix pushed

josemarluedke commented 1 year ago

Released in v0.6.0. Thanks for working on this.